Add support for AWS/EKS namespace
#1760
Open
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Smith <[email protected]>
| DimensionRegexps: []*regexp.Regexp{ | ||
| regexp.MustCompile(":cluster/(?P<ClusterName>[^/]+)$"), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
What's the difference with ContainerInsights a few lines above?
There was a problem hiding this comment.
ContainerInsights is a namespace for containerized application and worker node metrics that is not available by default for EKS clusters, as it requires an add-on to be installed.
AWS/EKS is a standard namespace that provides metrics from a Kubernetes cluster control plane.
There was a problem hiding this comment.
Ideally all the namespaces listed here should be supported?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It provide metrics such as
scheduler_pending_pods.